Skip to content

Fix inconsistency in master server listing

Hanicef requested to merge Hanicef/SRB2:fix-server-list-inconsistency into next

This patch fixes an issue with server listing where empty packets were sent to a server, interfering with it's response and blocking the SERVERINFO packet that the server replies with. I was originally under the assumption that it was harmless considering that empty packets would be ignored server-side, but it wasn't, and the server instead actually responded to it, thus responding with a bad packet and causing the server to not appear on the master server.

Here's the current behavior:

srb20034

Here's what happens with this patch:

srb20033

The severity of the issue is based on numerous factors though, like server state and UDP packet order, so the results are wildly inconsistent.

Edited by Hanicef

Merge request reports

Loading